Minor code refactor related to _clone.

kvraft/src/server.rs

@@ -122,7 +122,6 @@ impl KVServer {
             let _ = tx.send(message);
         };
         let snapshot_holder = Arc::new(SnapshotHolder::default());
-        let snapshot_holder_clone = snapshot_holder.clone();
         let ret = Arc::new(Self {
             me,
             state: Mutex::new(KVServerState::default()),
@@ -132,7 +131,10 @@ impl KVServer {
                 persister,
                 apply_command,
                 max_state_size_bytes,
-                move |index| snapshot_holder_clone.request_snapshot(index),
+                {
+                    let snapshot_holder = snapshot_holder.clone();
+                    move |index| snapshot_holder.request_snapshot(index)
+                },
             ),
             keep_running: AtomicBool::new(true),
             #[cfg(all(not(test), feature = "integration-test"))]

test_configs/src/raft/config.rs

@@ -310,14 +310,12 @@ impl Config {
         }
         let persister = self.log.lock().saved[index].clone();
 
-        let log_clone = self.log.clone();
+        let log = self.log.clone();
         let raft = Raft::new(
             clients,
             index,
             persister,
-            move |message| {
-                Self::apply_command(log_clone.clone(), index, message)
-            },
+            move |message| Self::apply_command(log.clone(), index, message),
             None,
             NO_SNAPSHOT,
         );

test_configs/src/rpcs.rs

@@ -192,6 +192,7 @@ pub fn register_kv_server<
 
     server.register_async_rpc_handler(GET.to_owned(), {
         let kv = kv.clone();
+        // Note: make_async_rpc_handler expects a FnOnce.
         make_async_rpc_handler(move |args| async move {
             kv.as_ref().get(args).await
         })